Invalid access to memory

Hello,

I have found a reproducible crash-bug, which only occurs in a strange race condition but could (and did :P) still happen ;)

Reproduce it as follows:

Open a SSH (SFTP) connection to a server and open a file on that server with a extenal texteditor (in my case Sublime Text 3).

Open a connection to a server that is not responding or very slow, I did this via a wrongly configured protocol-url -> just click this link then: winscp-ftps://web78:notarealpassword@webspace34.do.de

Now, while it tries to connect to the server on the unused port 990, save your file in the texteditor.

A crash occurs. This happens in 5.6.2 beta and 5.6.3 nightly.

So long,
Tobias


Screenshot:
https://screenshot.tbspace.de/onjehtxgcfa.png

Log:
WinSCP 5.6.3 (nightly build 4810 - 2014-11-09)

Error message:
Invalid access to memory.

Stack trace:
[000280F4] TCustomScpExplorerForm::AddQueueItem
[007E28B2] std::basic_filebuf<wchar_t, std::char_traits<wchar_t> >::imbue
[007E491A] _ungetch
[007E1894] std::basic_filebuf<wchar_t, std::char_traits<wchar_t> >::uflow
[77E2B466] ntdll.dll
[77DE012E] ntdll.dll.KiUserExceptionDispatcher
[0007A7A5] TCopyParamRule::TCopyParamRule
[00078774] std::vector<TEditorManager::TFileData, std::allocator<TEditorManager::TFileData> >::_Insert_n
[00035681] TCustomScpExplorerForm::Idle
[00058377] TNonVisualDataModule::DoIdle
[00058334] TNonVisualDataModule::SetScpExplorer
[0035FC20] System::Classes::TObservers::AddObserver
[773662F7] USER32.dll
[77366D35] USER32.dll
[773677BF] USER32.dll
[77367885] USER32.dll.DispatchMes

[007E2F1D] __Atexit
[007E44F7] C3025_3
[0007A7C7] TCopyParamRule::operator ==
[00078774] std::vector<TEditorManager::TFileData, std::allocator<TEditorManager::TFileData> >::_Insert_n
[00035681] TCustomScpExplorerForm::Idle
[00058377] TNonVisualDataModule::DoIdle
[00058334] TNonVisualDataModule::SetScpExplorer
[0035FC20] System::Classes::TObservers::AddObserver
[773662F7] USER32.dll
[77366D35] USER32.dll
[773677BF] USER32.dll
[77367885] USER32.dll.DispatchMessageW

Thanks for your report.
I have sent you an email with a debug version of WinSCP to address you have used to register on this forum.

This bug has been added to the tracker:
https://winscp.net/tracker/1241

I have sent you an email with a dev version of WinSCP to address you have used to register on this forum.